Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fiber] Add a unit test for ReactTopLevelText #8001

Merged
merged 1 commit into from
Oct 18, 2016
Merged

[Fiber] Add a unit test for ReactTopLevelText #8001

merged 1 commit into from
Oct 18, 2016

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Oct 18, 2016

This is a unit test for ReactTopLevelText, which is a new feature of ReactFiber.

Should I add more test cases?

@sebmarkbage
Copy link
Collaborator

lgtm. I'll merge this but you could also add a ReactDOMFiber variant of this test too if you want. We don't have any others but that would catch the error you were trying to fix.

@sebmarkbage sebmarkbage merged commit 3d7869a into facebook:master Oct 18, 2016
@koba04
Copy link
Contributor Author

koba04 commented Oct 19, 2016

Thanks!
ok, I'll add this test for ReactDOMFiber!

@koba04 koba04 deleted the add-a-unit-test-for-react-top-level-text branch October 19, 2016 00:57
@koba04 koba04 mentioned this pull request Oct 19, 2016
Merged
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
@koba04 @acusti
[Fiber] Add a unit test for ReactTopLevelText (facebook#8001)
bca7e8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sebmarkbage sebmarkbage

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koba04 @sebmarkbage @facebook-github-bot