Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passthrough updates for error boundaries #7949

Merged
merged 23 commits into from
Oct 15, 2016
Merged

Support passthrough updates for error boundaries #7949

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7ebc488
Initial pass at the easy case of updates (updates that start at the r…
jimfb Feb 11, 2016
9017999
Don't expect an extra componentWillUnmount call
gaearon Oct 12, 2016
965d12f
Remove duplicate expectations from the test
gaearon Oct 12, 2016
8236279
Fix style issues
gaearon Oct 12, 2016
d09d33f
Make naming consistent throughout the tests
gaearon Oct 12, 2016
aedd80d
receiveComponent() does not accept safely argument
gaearon Oct 12, 2016
5f869d2
Assert that lifecycle and refs fire for error message
gaearon Oct 12, 2016
3890a3a
Add more tests for mounting
gaearon Oct 13, 2016
045dcb5
Do not call componentWillMount twice on error boundary
gaearon Oct 13, 2016
b69d428
Document more of existing behavior in tests
gaearon Oct 13, 2016
e374fc7
Do not call componentWillUnmount() when aborting mounting
gaearon Oct 13, 2016
1fa0b36
Consistently display error messages in tests
gaearon Oct 14, 2016
8066a50
Add more logging to tests and remove redundant one
gaearon Oct 14, 2016
b0e6a08
Refactor tests
gaearon Oct 14, 2016
842bd75
Split complicated tests into smaller ones
gaearon Oct 14, 2016
0783dee
Assert clean unmounting
gaearon Oct 14, 2016
b36526e
Add assertions about update hooks
gaearon Oct 14, 2016
db4c306
Add more tests to document existing behavior and remove irrelevant de…
gaearon Oct 14, 2016
99dad51
Verify we can recover from error state
gaearon Oct 14, 2016
de5bdf1
Fix lint
gaearon Oct 14, 2016
c64dbfd
Error in boundary’s componentWillMount should propagate up
gaearon Oct 14, 2016
7026adc
Move calling componentWillMount() into mountComponent()
gaearon Oct 14, 2016
9f66fa4
Remove extra whitespace
gaearon Oct 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add more tests to document existing behavior and remove irrelevant de… 
…tails
  • Loading branch information
@gaearon
gaearon committed Oct 14, 2016
commit db4c3069a0ebcd297d7f455cf62dd9e13edc5ac9
Loading