Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use npm-run-script in PULL_REQUEST_TEMPLATE #7913

Merged
merged 1 commit into from
Oct 7, 2016
Merged

use npm-run-script in PULL_REQUEST_TEMPLATE #7913

merged 1 commit into from
Oct 7, 2016

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Oct 7, 2016

I think it's better to use npm-run-script than to use grunt command directly.
How to Contribute page is also using npm-run-script.

@gaearon gaearon merged commit 83381c1 into facebook:master Oct 7, 2016
@gaearon
Copy link
Collaborator

gaearon commented Oct 7, 2016

Thanks!

@koba04 koba04 deleted the fix-pull-request-template branch October 10, 2016 15:30
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
@koba04 @acusti
use npm-run-script in PULL_REQUEST_TEMPLATE (facebook#7913)
4d92433
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koba04 @gaearon @facebook-github-bot