Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing variable names #7863

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Oct 4, 2016

I think the variables is ReactElement, not ReactComponent.

@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2016

Oh, totally. Thanks.
I’ll wait for Travis and then merge.

@gaearon gaearon added this to the 15-next milestone Oct 4, 2016
@gaearon gaearon merged commit 30067fa into facebook:master Oct 4, 2016
@koba04
Copy link
Contributor Author

koba04 commented Oct 4, 2016

Thanks!

@koba04 koba04 deleted the fix-confusing-variable-names branch October 4, 2016 13:51
@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
zpao pushed a commit that referenced this pull request Oct 4, 2016
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants