Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ShallowRenderer #7739

Merged
merged 2 commits into from
Oct 4, 2016
Merged

Refactor ShallowRenderer #7739

merged 2 commits into from
Oct 4, 2016

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Sep 15, 2016

I've refactored ReactShallowRenderer for readability, which is not changing the behavior.
If this was merged, I'll add type annotations with Flow.

@gaearon
Copy link
Collaborator

gaearon commented Sep 15, 2016

This fails Flow: https://travis-ci.org/facebook/react/jobs/160155787

gaearon
gaearon requested changes Sep 15, 2016
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Flow

@koba04
Copy link
Contributor Author

koba04 commented Sep 15, 2016

@gaearon
Thank you for your review!
Failing Travis is because of #7736. This PR seems to be not relevant.

@ghost ghost added the CLA Signed label Sep 15, 2016
@gaearon
Copy link
Collaborator

gaearon commented Sep 15, 2016

OK, let’s wait for that to land and then try this again. Thanks!

@aweary
Copy link
Contributor

aweary commented Sep 15, 2016

@gaearon @koba04 I've merged #7736, so those flow errors should be resolved now 👍

@ghost ghost added the CLA Signed label Sep 15, 2016
@ghost ghost added the CLA Signed label Sep 16, 2016
@koba04
Copy link
Contributor Author

koba04 commented Sep 16, 2016

@gaearon @aweary Thanks! rebased.

aweary
aweary approved these changes Oct 3, 2016
View reviewed changes
Copy link
Contributor

@aweary aweary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aweary aweary added this to the 15-next milestone Oct 3, 2016
@koba04
Copy link
Contributor Author

koba04 commented Oct 4, 2016

@aweary Thank you!
@gaearon Flow has been fixed.

@gaearon gaearon self-assigned this Oct 4, 2016
@gaearon gaearon merged commit 85b0377 into facebook:master Oct 4, 2016
@gaearon gaearon removed their assignment Oct 4, 2016
@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2016

Thanks!

1 similar comment
@koba04
Copy link
Contributor Author

koba04 commented Oct 4, 2016

Thanks!

@koba04 koba04 deleted the refactor-shallow-renderer branch October 4, 2016 13:52
@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
zpao pushed a commit that referenced this pull request Oct 4, 2016
@koba04 @zpao
Refactor ShallowRenderer (#7739)
9b025df 
* Separate ReactShallowRenderer from TestUtils

* Use ES classes to ReactShallowRenderer

(cherry picked from commit 85b0377)
acusti pushed a commit to brandcast/react that referenced this pull request Mar 15, 2017
@koba04 @acusti
Refactor ShallowRenderer (facebook#7739)
7e1a564 
* Separate ReactShallowRenderer from TestUtils

* Use ES classes to ReactShallowRenderer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@aweary aweary aweary approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
15.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@koba04 @gaearon @aweary @zpao @facebook-github-bot