Move from createClass to ES classes using react-codemod/transforms/class #7679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
I'm assuming we might have had a reason to not do this already but I'm not sure. @spicyj, @gaearon, or @keyanzhang might know best. Seems fine to do (though we might want to look to see if the inevitable byte cost for the class transform is worth it) |
|
I think this is fine. We already use classes elsewhere. |
|
Thanks! |
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Sep 9, 2016
zpao
pushed a commit
that referenced
this pull request
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run react-codemod/transforms/class.js to
srcdirectory, which is for moving React codebase to ES classes components.ref. #7321