Use aliasify everywhere instead of browserify-global-shim #7476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
| // the rest of ReactElement. | ||
| var shimSharedModulesFiberFiles = {}; | ||
| for (var key in shimSharedModulesFiles) { | ||
| if (!/ReactElement/.test(key)) { |
There was a problem hiding this comment.
I refactored this already so this special case for Fiber is no longer needed.
I already had to aliasify to have better control over the requires so we might as well do it everywhere for consistency. This probably makes it easier to rebase the rollup work too because aliases seems to be how you solve this in that world.
sebmarkbage
force-pushed
the
usealiasify
branch
from
f044e6b
to
9547a20
Compare
|
k |
zpao
pushed a commit
that referenced
this pull request
Oct 4, 2016
I already had to aliasify to have better control over the requires so we might as well do it everywhere for consistency. This probably makes it easier to rebase the rollup work too because aliases seems to be how you solve this in that world. (cherry picked from commit c8f7215)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already had to aliasify to have better control over the requires so we might as well do it everywhere for consistency.
This probably makes it easier to rebase the rollup work too. Aliases seems to be how you solve this in that world, since you can't just swap out the expression in an ES import.