Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an ordered property list for inputs, fix some Chrome number input issues #7474

Closed
wants to merge 19 commits into from
Closed

Use an ordered property list for inputs, fix some Chrome number input issues #7474

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
eaf986b
Store properties as a list
nhunzaker Aug 4, 2016
5e92612
Remove mutation methods
nhunzaker Aug 4, 2016
f836654
Add property assignment test for similar value.
nhunzaker Aug 4, 2016
2f5050e
No need to update value/checked on updateWrapper or have iOS/Android …
nhunzaker Aug 5, 2016
5a8c422
Switch back to object config. Add priority field
nhunzaker Aug 6, 2016
7bfcb06
No need to add forced update branch
nhunzaker Aug 6, 2016
2032fc8
Do not remove mutation method. Keep change small
nhunzaker Aug 6, 2016
762fca3
Use mutation method for value. Add test coverage for all states
nhunzaker Aug 6, 2016
6238eec
defaultChecked chrome bug can be handled as mutation method
nhunzaker Aug 7, 2016
3739426
Faster enumeration of ordered props
nhunzaker Aug 8, 2016
e8c77cd
Only order props for inputs
nhunzaker Aug 9, 2016
4d54faa
Revert null assignment condition removal
nhunzaker Aug 9, 2016
0495c8f
No need to prioritize defaultValue and defaultChecked
nhunzaker Aug 9, 2016
1dfbd8c
Eliminate some white space. Add comment about order property.
nhunzaker Aug 9, 2016
cc54aa4
Place min/max ahead of value input prop order list
nhunzaker Aug 12, 2016
0501c39
There must be a post mount wrapper
nhunzaker Aug 13, 2016
d39d919
Re-eliminate the postmount wrapper with a special defaultValue mutati…
nhunzaker Aug 13, 2016
5d8c8ef
Be sure to update value attributes
nhunzaker Sep 16, 2016
4e5ac47
Add test case for progress elements
nhunzaker Sep 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Place min/max ahead of value input prop order list
  • Loading branch information
@nhunzaker
nhunzaker committed Sep 29, 2016
commit cc54aa40b9fd485a694f21ce52254026fa6c6078
3 changes: 2 additions & 1 deletion src/renderers/dom/shared/HTMLDOMPropertyConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ var HTMLDOMPropertyConfig = {
// Make sure we set .step before .value (setting .value before .step
// means .value is rounded on mount: based upon step precision)
'step',
// Min and max need to be set before value for range inputs.
// Fix bug in range inputs initial render
// https://github.com/facebook/react/issues/7170
'min',
'max',
'value',
Expand Down