Gulp: lint, flow, and version-check #7174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
Looks great, thanks for kicking this off! |
|
Thanks @maxdeviant! |
zpao
pushed a commit
that referenced
this pull request
Jul 8, 2016
* Add plugin loading for gulp * Convert `lint` task to gulp * Convert `flow` task to gulp * Convert `version-check` task to gulp * Add missing semicolons (cherry picked from commit 69703e0)
usmanajmal
pushed a commit
to usmanajmal/react
that referenced
this pull request
Jul 11, 2016
* Add plugin loading for gulp * Convert `lint` task to gulp * Convert `flow` task to gulp * Convert `version-check` task to gulp * Add missing semicolons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of @sebmarkbage's comments on #7172, I am opting for smaller PRs to convert the grunt tasks over to gulp. These tasks should be unaffected by the changes in #7164 and #7168.
I also decided on a different approach for splitting the tasks, after discovering that storing the tasks themselves in individual files will be deprecated in gulp 4. The task bodies are now stored in separate files, but registered with gulp in the main gulpfile. This also makes the dependencies between different tasks much clearer.
The grunt tasks with the same name have been adjusted to wrap the new gulp tasks.
Converted Tasks
gulp lintgulp eslintgulp flowgulp version-checkThis PR would progress #4927 and #6656.