Issue #383 : Error message for using refs outside of render() is difficult to underst...#716
Merged
vjeux merged 3 commits intofacebook:masterfrom Dec 28, 2013
Merged
Issue #383 : Error message for using refs outside of render() is difficult to underst...#716vjeux merged 3 commits intofacebook:masterfrom
vjeux merged 3 commits intofacebook:masterfrom
Conversation
src/core/ReactOwner.js
Outdated
Collaborator
There was a problem hiding this comment.
Looks like you have an unbalanced paren here.
Contributor
|
Thanks a lot @bitshadow, do you mind signing the CLA so we can merge it in? https://developers.facebook.com/opensource/cla Thanks! |
Contributor
Author
|
@vjeux Done. |
src/core/ReactOwner.js
Outdated
Collaborator
There was a problem hiding this comment.
Er, now you have an extra closing paren? :) The message for removing looks okay.
Contributor
|
Seems like this is ready to be merged |
vjeux
added a commit
that referenced
this pull request
Dec 28, 2013
Issue #383 : Error message for using refs outside of render() is difficult to underst...
This was referenced Mar 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and