Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "unexpected batch number" a warning #7133

Merged
merged 1 commit into from
Jun 27, 2016

Conversation

sophiebits
Copy link
Collaborator

This was added to catch internal errors in React but doesn't seem to be doing much good except frustrating people more when their apps throw (#6895, FB-internal t11950821). Until more proper error boundaries land, let's make this a warning.

This was added to catch internal errors in React but doesn't seem to be doing much good except frustrating people more when their apps throw (facebook#6895, FB-internal t11950821). Until more proper error boundaries land, let's make this a warning.
@jimfb
Copy link
Contributor

jimfb commented Jun 27, 2016

Seems reasonable. Are we sure that the "unexpected batch number" is due to prior errors in the user's application, and not due to a subtle bug in React? We've seen a bunch of super subtle/complex bugs related to this code path, and it isn't super clear to me that people are hitting this do to recoverable bugs in user land rather than a subtle bug in React land.

Regardless, I suppose there isn't really a reason to make this fatal, so this change seems reasonable.

@sophiebits
Copy link
Collaborator Author

sophiebits commented Jun 27, 2016

The two people in #6895 who saw it, saw it because of an earlier error – and we did in the FB task too. So it's possible there could be subtle bugs in React that this would catch (which is why I'm leaving it instead of removing it completely) but I don't think we've seen any evidence of that so far.

@sophiebits sophiebits merged commit abcd567 into facebook:master Jun 27, 2016
@zpao zpao modified the milestones: 15-next, 15.3.0 Jul 13, 2016
zpao pushed a commit that referenced this pull request Jul 13, 2016
This was added to catch internal errors in React but doesn't seem to be doing much good except frustrating people more when their apps throw (#6895, FB-internal t11950821). Until more proper error boundaries land, let's make this a warning.
(cherry picked from commit abcd567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants