Pin babylon at 6.8.0 for ESLint to work #7008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
|
I can do a patch release (in babel) to fix the unknown node type issue in a bit edit: but now I'm not sure that it fixes this particular issue? |
|
@hzoo I tried upgrading ESLint to 2.x and that solved the issue, but we have quite a few custom rules here so it won't be an easy migration. I think it's fine to pin babylon at 6.8.0 for now. Thanks! |
|
Yeah there were a good amount of changes in 2.x. And FYI, when you do update to 2.x, update babel-eslint to 6.x too. Can check the gitter/ping me if help is needed |
|
Thanks @hzoo! 😃 |
zpao
pushed a commit
that referenced
this pull request
Jun 14, 2016
(cherry picked from commit 46cd6a0)
|
This should be fixed now* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel/babylon#25 broke our linter (
Error: Unknown node type TypeParameter.). Upgrading ESLint to 2.x would be the right way to go, but we can just pinbabylonat 6.8.0 to do a quick fix.CC @zpao @hzoo @kittens