Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setProps and replaceProps completely #6921

Merged
merged 1 commit into from
Jun 9, 2016
Merged

Remove setProps and replaceProps completely #6921

merged 1 commit into from
Jun 9, 2016

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented May 30, 2016

setProps and replaceProps are removed completely on v15.0

@koba04 koba04 force-pushed the remove-set-props-and-replace-props branch from 878b55a to bbf9ef8 Compare May 30, 2016 16:28
@ghost
Copy link

ghost commented May 30, 2016

@koba04 updated the pull request.

jimfb
jimfb reviewed Jun 9, 2016
View reviewed changes
src/renderers/shared/stack/reconciler/__tests__/ReactCompositeComponentState-test.js
@@ -140,8 +140,7 @@ describe('ReactCompositeComponent-state', function() {
);
ReactDOM.render(
<TestComponent stateListener={stateListener} nextColor="green" />,
container,
instance.peekAtCallback('setProps')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to remove this one. This isn't actually the same as the setProps that you removed elsewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jimfb Thank you! I got it fixed!

@koba04 koba04 force-pushed the remove-set-props-and-replace-props branch from bbf9ef8 to dd739f8 Compare June 9, 2016 05:14
@ghost
Copy link

ghost commented Jun 9, 2016

@koba04 updated the pull request.

@jimfb
Copy link
Contributor

jimfb commented Jun 9, 2016

Ok, this looks good, thanks @koba04!

@jimfb jimfb merged commit 731e429 into facebook:master Jun 9, 2016
@koba04
Copy link
Contributor Author

koba04 commented Jun 10, 2016

Thank you!

@koba04 koba04 deleted the remove-set-props-and-replace-props branch June 10, 2016 00:22
@zpao
Copy link
Member

zpao commented Jun 14, 2016

Sorry to do this, but I'm going to revert this. Can you submit separate PRs for the changes to docs/ and src/ (this won't cherry-pick cleanly and will screw up some of the release tracking). In the future we should keep docs and code changes separate unless it's the initial introduction or removal of a feature (at least until we have a ship from master release process and we'll have other things to figure out then).

@zpao zpao mentioned this pull request Jun 14, 2016
Merged
@koba04
Copy link
Contributor Author

koba04 commented Jun 15, 2016

Thank you, I got it!
I'll submit separate PRs for this!

This was referenced Jun 15, 2016
Merged
Merged
@zpao zpao mentioned this pull request Jun 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koba04 @jimfb @zpao