Set this.props on elements in prod mode #4215
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops. Introduced in facebook#4172.
|
How did unit tests pass? We really should have unit tests run in both prod and dev mode. |
|
Lots of them test dev-only warnings. Agree with the sentiment though. |
sophiebits
added a commit
that referenced
this pull request
Jun 24, 2015
Set this.props on elements in prod mode
|
We were(/should) switch to a jasmine expectWarn instead of expecting a spy/mock. It's cleaner, and would allow us to disable the inspect when running the tests in prod mode (or better yet, inverse the expect, and expect things to NOT warn in prod). #2814 We reverted #2814 because it created some sort of push-blocking dependency cycle or something. Probably worth reviving though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops. Introduced in #4172.