Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set change event type in SyntheticEvent #4206

Merged
merged 2 commits into from
Jun 24, 2015
Merged

Set change event type in SyntheticEvent #4206

merged 2 commits into from
Jun 24, 2015

Conversation

yiminghe
Copy link
Contributor

forget to set SyntheticEvent type.

select event:

react/src/renderers/dom/client/eventPlugins/SelectEventPlugin.js

Line 117 in 3dc4384

syntheticEvent.type = 'select';

@jimfb
Copy link
Contributor

jimfb commented Jun 24, 2015

Looks good, thanks @yiminghe!

@jimfb jimfb changed the title fix change event type Set change event type in SyntheticEvent Jun 24, 2015
jimfb added a commit that referenced this pull request Jun 24, 2015
@jimfb
Merge pull request #4206 from yiminghe/fix_change_type
484e20c 
Set change event type in SyntheticEvent
@jimfb jimfb merged commit 484e20c into facebook:master Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yiminghe @jimfb @facebook-github-bot