unmountChildren was missing an Object.hasOwnProperty check (src/core/ReactChildReconciler.js) #3749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct.hasOwnProperty check
|
I'll take this for consistency with the other functions here, but I'd really discourage you from mutating Object.prototype. Most libraries break if you do. For example, jQuery doesn't support it. |
sophiebits
added a commit
that referenced
this pull request
Apr 26, 2015
unmountChildren was missing an Object.hasOwnProperty check (src/core/ReactChildReconciler.js)
|
Yea, we'll definitely break in other places too (eg, #3665 was entirely about getting rid of hasOwnProperty for objects we created and know can't have certain keys that would be an issue). This looks like a case where we're already using our generated ids as keys so we should be able to consider it safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a method to Object.prototype caused react to crash on me when unloading a component. Turns out that ReactChildReconciler::unmountChildren was missing a check renderedChildren.hasOwnProperty(name)