Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webkitdirectory and nwdirectory attributes for input file #3644

Merged
merged 1 commit into from
Apr 10, 2015

Conversation

gregorym
Copy link
Contributor

Add attributes for

  • webkitdirectory
  • nwdirectory

Add attributes for <input type="file" />
* webkitdirectory
* nwdirectory
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jimfb added a commit that referenced this pull request Apr 10, 2015
Add webkitdirectory and nwdirectory attributes for input file
@jimfb jimfb merged commit 5e9623d into facebook:master Apr 10, 2015
@jimfb
Copy link
Contributor

jimfb commented Apr 10, 2015

@gregorym, thanks!

@jimfb
Copy link
Contributor

jimfb commented Apr 10, 2015

@gregorym Just noticed that there is a related issue (#3468) which specifies two additional properties. Can we get a PR for mozdirectory and directory merged too?

@zpao
Copy link
Member

zpao commented Apr 10, 2015

I actually think we should revert this and take a closer look.

  1. Those properties don't conform to our pattern (camelCase, even if the property itself isn't)
  2. This isn't a standard (yet?). It's ok for us to add support for esoteric things but we should not do it blindly.

I'm going to revert and we can discuss some more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants