Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip SelectEventPlugin extraction if no listeners #3639

Merged
merged 1 commit into from
Apr 9, 2015
Merged

Skip SelectEventPlugin extraction if no listeners #3639

merged 1 commit into from
Apr 9, 2015

Commits on Apr 9, 2015

  1. Skip SelectEventPlugin extraction if no listeners 

    If there are no listeners for `onSelect` yet, do not extract events. This way we can avoid issues where listeners have been set up for some event dependencies for `SelectEventPlugin`, but not all.

For instance, if `topMouseDown` has been registered but not `topMouseUp`, event extraction will set the `mouseDown` flag to true but never unset it. This leads to bugs when `onSelect` is registered and should be firing during normal key behavior. Since no `topMouseUp` has yet occurred to unset the flag, `onSelect` fails to fire.
    Isaac Salier-Hellendag committed Apr 9, 2015
    Configuration menu
    Copy the full SHA
    47b147f View commit details
    Browse the repository at this point in the history