Skip to content

Don't hydrate Elements that have dangerouslySetInnerHTML and suppressHydrationWarning#35871

Open
morbidick wants to merge 1 commit intofacebook:mainfrom
morbidick:feature/suppressHydrationWarningMeansNoHydration
Open

Don't hydrate Elements that have dangerouslySetInnerHTML and suppressHydrationWarning#35871
morbidick wants to merge 1 commit intofacebook:mainfrom
morbidick:feature/suppressHydrationWarningMeansNoHydration

Conversation

@morbidick
Copy link

Summary

In React 18 it was possible to set dangerouslySetInnerHTML and suppressHydrationWarning for elements you would know that change before hydration, this could be:

  • react rendered script tags that get modified by the included scripts
  • Server Side Includes thar replace parts of the dom

examples are: #32975 or #24430

if you ask a LLM how to fix those warnings they persist on suppressHydrationWarning still being the way to go with React 19

How did you test this change?

I added a simple test case and had a local page where i tried it.

@meta-cla
Copy link

meta-cla bot commented Feb 23, 2026

Hi @morbidick!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Feb 23, 2026

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant