Add reporting modes for react-hooks/exhaustive-effect-dependencies and temporarily enable #35365
+293
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poteto
approved these changes
Dec 15, 2025
| description: | ||
| 'Validates that effect dependencies are exhaustive and without extraneous values', | ||
| preset: LintRulePreset.Off, | ||
| preset: LintRulePreset.Recommended, |
Member
There was a problem hiding this comment.
technically this shouldn't be needed as we don't use presets internally, but okay to leave in if we plan to ship.
if you choose to leave it, you’ll need to manually add the rule to the eslint config for this fixture
Contributor
Author
There was a problem hiding this comment.
I only changed this because the rule noops in the eslint-v9 fixture with it off. But if we can control it separately internally I can disable the fixture test while we experiment.
|
Comparing: bcf97c7...61f0cb3 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
…d temporarily enable (#35365) `react-hooks/exhaustive-effect-dependencies` from `ValidateExhaustiveDeps` reports errors for both missing and extra effect deps. We already have `react-hooks/exhaustive-deps` that errors on missing dependencies. In the future we'd like to consolidate this all to the compiler based error, but for now there's a lot of overlap. Let's enable testing the extra dep warning by splitting out reporting modes. This PR - Creates `on`, `off`, `missing-only`, and `extra-only` reporting modes for the effect dep validation flag - Temporarily enables the new rule with `extra-only` in `eslint-plugin-react-hooks` - Adds additional null checking to `manualMemoLoc` to fix a bug found when running against the fixture DiffTrain build for [88ee1f5](88ee1f5)
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2025
…d temporarily enable (#35365) `react-hooks/exhaustive-effect-dependencies` from `ValidateExhaustiveDeps` reports errors for both missing and extra effect deps. We already have `react-hooks/exhaustive-deps` that errors on missing dependencies. In the future we'd like to consolidate this all to the compiler based error, but for now there's a lot of overlap. Let's enable testing the extra dep warning by splitting out reporting modes. This PR - Creates `on`, `off`, `missing-only`, and `extra-only` reporting modes for the effect dep validation flag - Temporarily enables the new rule with `extra-only` in `eslint-plugin-react-hooks` - Adds additional null checking to `manualMemoLoc` to fix a bug found when running against the fixture DiffTrain build for [88ee1f5](88ee1f5)
This was referenced Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-hooks/exhaustive-effect-dependenciesfromValidateExhaustiveDepsreports errors for both missing and extra effect deps. We already havereact-hooks/exhaustive-depsthat errors on missing dependencies. In the future we'd like to consolidate this all to the compiler based error, but for now there's a lot of overlap. Let's enable testing the extra dep warning by splitting out reporting modes.This PR
on,off,missing-only, andextra-onlyreporting modes for the effect dep validation flagextra-onlyineslint-plugin-react-hooksmanualMemoLocto fix a bug found when running against the fixture