[compiler] Consider setter from useOptimistic non-reactive #35141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
rickhanlonii
commented
Nov 14, 2025
| isUseReducerType(id) || // dispatcher | ||
| type_.shapeId === 'BuiltInUseTransition' // startTransition | ||
| type_.shapeId === 'BuiltInUseTransition' || // startTransition | ||
| isUseOptimisticType(id) // setOptimistic |
Member
Author
There was a problem hiding this comment.
tbh idk what this function is doing and why some hooks use type._shapeId directly?
Member
There was a problem hiding this comment.
i think we just didn't add isFooType() helpers for all the types checked here
|
|
||
| export function isUseOptimisticType(id: Identifier): boolean { | ||
| return ( | ||
| id.type.kind === 'Function' && id.type.shapeId === 'BuiltInUseOptimistic' |
Member
There was a problem hiding this comment.
id.type will be Object i think
Member
Author
There was a problem hiding this comment.
I switched this to Object, but both seem to work. The real fix was adding it here:
react/compiler/packages/babel-plugin-react-compiler/src/HIR/HIR.ts
Lines 1966 to 1970 in 6bf1a07
josephsavona
approved these changes
Nov 17, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 22, 2025
…35141) Closes facebook#35138 DiffTrain build for [0972e23](facebook@0972e23)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Nov 22, 2025
…35141) Closes facebook#35138 DiffTrain build for [0972e23](facebook@0972e23)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35138