-
Notifications
You must be signed in to change notification settings - Fork 48.8k
Added support for the 'low', 'high', and 'optimum' attributes that are missing from the <meter> tag. #3513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…e <meter> tag requires.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Yea, this seems fine. Can you actually remove the last 2 commits? We'll update docs manually with other attributes and the merge is extraneous since we'll just merge this back. |
CLA signed. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
# move back 2 commits
git reset --hard HEAD~2
# force push since you're changing history in the remote
git push -f I won't lie and say those aren't risky operations, especially with a merge in ther :) There's a chance you'll screw it all up (I certainly have). Luckily it's a smaller change so easily reproducible. In the future you'll probably want to do PRs in a branch anyway (and not on master). If you don't feel comfortable, then no worries at all. I can grab the code commit and push that with you as the author. |
Thanks! I think it updated properly? Let me know if there are still issues. |
Awesome, thanks!. Don't worry about the failing test, that's not you. |
Added support for the 'low', 'high', and 'optimum' attributes that are missing from the <meter> tag.
Added support for the 'low', 'high', and 'optimum' attributes that are missing from the <meter> tag.
Added support for the 'low', 'high', and 'optimum' attributes that are missing from the <meter> tag.
Added support for the 'low', 'high', and 'optimum' attributes that are missing from the <meter> tag.
No description provided.