Skip to content

[flags] disableLegacyMode in native-fb #35120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackpope merged 1 commit into from
Nov 12, 2025
Merged

[flags] disableLegacyMode in native-fb #35120

jackpope merged 1 commit into from
Nov 12, 2025

Conversation

@rickhanlonii
Copy link
Member

@rickhanlonii rickhanlonii commented Nov 12, 2025

this is failing test too because we need the legacy mode in the react package until we fix the tests

@meta-cla meta-cla bot added the CLA Signed label Nov 12, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Nov 12, 2025
@react-sizebot
Copy link

react-sizebot commented Nov 12, 2025 •
edited
Loading

Comparing: 1ea46df...92d5278

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.16 kB 608.16 kB = 107.64 kB 107.65 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 666.18 kB 666.18 kB = 117.35 kB 117.35 kB
facebook-www/ReactDOM-prod.classic.js = 693.31 kB 693.31 kB = 121.97 kB 121.98 kB
facebook-www/ReactDOM-prod.modern.js = 683.73 kB 683.73 kB = 120.36 kB 120.36 kB
react-native/implementations/ReactFabric-prod.js +2.01% 379.70 kB 387.33 kB +1.66% 65.86 kB 66.95 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js = 17.20 kB 16.74 kB = 3.74 kB 3.61 kB
facebook-react-native/react-dom/cjs/ReactDOM-prod.js = 6.68 kB 6.48 kB = 1.83 kB 1.81 kB
facebook-react-native/react-dom/cjs/ReactDOM-profiling.js = 6.68 kB 6.48 kB = 1.83 kB 1.81 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/implementations/ReactFabric-prod.js +2.01% 379.70 kB 387.33 kB +1.66% 65.86 kB 66.95 kB
react-native/implementations/ReactFabric-profiling.js +1.85% 453.62 kB 462.03 kB +1.62% 76.41 kB 77.64 kB
react-native/implementations/ReactFabric-prod.fb.js +1.71% 385.78 kB 392.36 kB +1.74% 66.81 kB 67.97 kB
react-native/implementations/ReactFabric-dev.js +1.64% 759.74 kB 772.22 kB +1.51% 121.50 kB 123.34 kB
react-native/implementations/ReactFabric-dev.fb.js +1.62% 765.17 kB 777.58 kB +1.47% 121.43 kB 123.21 kB
react-native/implementations/ReactFabric-profiling.fb.js +1.58% 460.20 kB 467.47 kB +1.58% 76.80 kB 78.01 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js +1.24% 1,139.39 kB 1,153.56 kB +1.01% 188.28 kB 190.18 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js +1.22% 588.44 kB 595.65 kB +1.12% 103.77 kB 104.93 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js +1.19% 665.57 kB 673.50 kB +1.14% 113.97 kB 115.26 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js +1.18% 1,156.24 kB 1,169.83 kB +0.94% 191.19 kB 192.98 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js +1.17% 594.21 kB 601.15 kB +1.11% 104.84 kB 106.00 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js +1.14% 671.77 kB 679.43 kB +1.13% 115.12 kB 116.42 kB
facebook-react-native/react/cjs/React-dev.js +1.00% 52.09 kB 52.61 kB +0.62% 11.54 kB 11.61 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js = 17.20 kB 16.74 kB = 3.74 kB 3.61 kB
facebook-react-native/react-dom/cjs/ReactDOM-prod.js = 6.68 kB 6.48 kB = 1.83 kB 1.81 kB
facebook-react-native/react-dom/cjs/ReactDOM-profiling.js = 6.68 kB 6.48 kB = 1.83 kB 1.81 kB

Generated by 🚫 dangerJS against 92d5278

@rickhanlonii rickhanlonii force-pushed the rh/ff-disable-lm-native-fb branch from 27e483c to df7dfed Compare November 12, 2025 17:21
@rickhanlonii rickhanlonii force-pushed the rh/ff-disable-lm-native-fb branch from df7dfed to 92d5278 Compare November 12, 2025 18:15
@jackpope jackpope merged commit bbe3f4d into facebook:main Nov 12, 2025
238 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 12, 2025
@jackpope
[flags] disableLegacyMode in native-fb (#35120)
038dc4b 
this is failing test too because we need the legacy mode in the react
package until we fix the tests

DiffTrain build for [bbe3f4d](bbe3f4d)
This was referenced Nov 13, 2025
Closed
Merged
Closed
manNomi pushed a commit to manNomi/react that referenced this pull request Nov 15, 2025
@rickhanlonii @manNomi
[flags] disableLegacyMode in native-fb (facebook#35120)
dfc7c58 
this is failing test too because we need the legacy mode in the react
package until we fix the tests
github-actions bot pushed a commit to code/lib-react that referenced this pull request Nov 15, 2025
@pull
[flags] disableLegacyMode in native-fb (facebook#35120)
c8afb3a 
this is failing test too because we need the legacy mode in the react
package until we fix the tests

DiffTrain build for [bbe3f4d](facebook@bbe3f4d)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Nov 15, 2025
@pull
[flags] disableLegacyMode in native-fb (facebook#35120)
4417e23 
this is failing test too because we need the legacy mode in the react
package until we fix the tests

DiffTrain build for [bbe3f4d](facebook@bbe3f4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackpope jackpope jackpope approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rickhanlonii @react-sizebot @jackpope