[Flight] Fix debug info filtering to include later resolved I/O #35036
+45
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In facebook#35019, we excluded debug I/O info from being considered for enhancing the owner stack if it resolved after the defined `endTime` option that can be passed to the Flight client. However, we should include any I/O that was awaited before that end time, even if it resolved later.
github-actions
bot
added
the
React Core Team
|
Comparing: 561ee24...2e334bd Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
approved these changes
Nov 3, 2025
unstubbable
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 4, 2025
[diff facebook/react@561ee24d...67f7d47a](facebook/react@561ee24...67f7d47) <details> <summary>React upstream changes</summary> - facebook/react#35036 </details>
huozhi
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 12, 2025
[diff facebook/react@561ee24d...67f7d47a](facebook/react@561ee24...67f7d47) <details> <summary>React upstream changes</summary> - facebook/react#35036 </details>
huozhi
pushed a commit
to vercel/next.js
that referenced
this pull request
Nov 12, 2025
[diff facebook/react@561ee24d...67f7d47a](facebook/react@561ee24...67f7d47) <details> <summary>React upstream changes</summary> - facebook/react#35036 </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #35019, we excluded debug I/O info from being considered for enhancing the owner stack if it resolved after the defined
endTimeoption that can be passed to the Flight client. However, we should include any I/O that was awaited before that end time, even if it resolved later.