Don't add 'px' to strokeDashoffset CSS Properties #3499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a SVG CSS Property. The standard expects values or percentages, and adding "px" to the value will break it. http://www.w3.org/TR/SVG/painting.html#StrokeDashoffsetProperty
| @@ -34,7 +34,8 @@ var isUnitlessNumber = { | |||
| // SVG-related properties | |||
| fillOpacity: true, | |||
| strokeOpacity: true, | |||
| strokeWidth: true | |||
| strokeWidth: true, | |||
| strokeDashoffset: true | |||
There was a problem hiding this comment.
Can you move this up and maintain ABC order?
There was a problem hiding this comment.
Yes! I missed that and just updated it. Thank you!
|
👍 thanks! |
zpao
added a commit
that referenced
this pull request
Mar 24, 2015
Don't add 'px' to strokeDashoffset CSS Properties
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 13, 2015
Don't add 'px' to strokeDashoffset CSS Properties
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 17, 2015
Don't add 'px' to strokeDashoffset CSS Properties
zpao
added a commit
to zpao/react
that referenced
this pull request
Apr 18, 2015
Don't add 'px' to strokeDashoffset CSS Properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a SVG CSS Property. The standard expects values or percentages, and adding "px" to the value will break it.
http://www.w3.org/TR/SVG/painting.html#StrokeDashoffsetProperty