Skip to content

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Sep 11, 2025

Stacked on #34464

We'll probably need to start with an allow-list first because some tests are not compatible (specifically ones testing RDT integration).

Maybe this will just be an extra config if it's too slow. Ideally we take a store snapshot after each act. Not sure yet how that'll look to not be too disruptive.

Need to go through some of the instrumentation failures this is currently reporting. The ones related to react-test-renderer I'm not too worried. That renderer is deprecated anyway.

@meta-cla meta-cla bot added the CLA Signed label Sep 11, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Sep 11, 2025
@react-sizebot
Copy link

react-sizebot commented Sep 11, 2025

Comparing: b1c519f...e8c6afb

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.65 kB 530.65 kB = 93.49 kB 93.49 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 658.20 kB 658.20 kB = 115.79 kB 115.79 kB
facebook-www/ReactDOM-prod.classic.js = 682.36 kB 682.36 kB = 119.83 kB 119.83 kB
facebook-www/ReactDOM-prod.modern.js = 672.79 kB 672.79 kB = 118.14 kB 118.13 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against e8c6afb

@eps1lon eps1lon force-pushed the sebbie/09-11-run_all_tests_with_devtools_attached branch from 30c12d0 to e8c6afb Compare September 11, 2025 13:09
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a separate test variant that runs with dev tools attached? We should test both paths so we don't accidentally depend on devtools for behavior.

@rickhanlonii
Copy link
Member

With a separate variant, we will also be able to exclude certain paths (like the linter) and use the @gate pragma to disable broken tests until they're fixed.

@eps1lon
Copy link
Collaborator Author

eps1lon commented Sep 11, 2025

This is a draft for a reason. I just needed a picture from CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants