-
Notifications
You must be signed in to change notification settings - Fork 49.5k
Run all tests with devtools attached #34466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Run all tests with devtools attached #34466
Conversation
Comparing: b1c519f...e8c6afb Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
will probably remove later. The main goal here is to establish smoke tests
30c12d0
to
e8c6afb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create a separate test variant that runs with dev tools attached? We should test both paths so we don't accidentally depend on devtools for behavior.
With a separate variant, we will also be able to exclude certain paths (like the linter) and use the |
This is a draft for a reason. I just needed a picture from CI |
Stacked on #34464
We'll probably need to start with an allow-list first because some tests are not compatible (specifically ones testing RDT integration).
Maybe this will just be an extra config if it's too slow. Ideally we take a store snapshot after each
act
. Not sure yet how that'll look to not be too disruptive.Need to go through some of the instrumentation failures this is currently reporting. The ones related to
react-test-renderer
I'm not too worried. That renderer is deprecated anyway.