Skip to content

[compiler] Remove @babel/plugin-proposal-private-methods #34458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ArnaudBarre wants to merge 1 commit into from
Closed

[compiler] Remove @babel/plugin-proposal-private-methods #34458

ArnaudBarre wants to merge 1 commit into from

Conversation

@ArnaudBarre
Copy link
Contributor

@ArnaudBarre ArnaudBarre commented Sep 10, 2025 •
edited by josephsavona
Loading

No description provided.

@meta-cla
Copy link

meta-cla bot commented Sep 10, 2025

Hi @ArnaudBarre!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla
Copy link

meta-cla bot commented Sep 10, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed label Sep 10, 2025
@react-sizebot
Copy link

react-sizebot commented Oct 2, 2025

Comparing: 886b3d3...1ee8e65

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.65 kB 530.65 kB = 93.49 kB 93.49 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 658.20 kB 658.20 kB = 115.79 kB 115.79 kB
facebook-www/ReactDOM-prod.classic.js = 682.36 kB 682.36 kB = 119.83 kB 119.83 kB
facebook-www/ReactDOM-prod.modern.js = 672.79 kB 672.79 kB = 118.14 kB 118.14 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 1ee8e65

@SimenB SimenB mentioned this pull request Oct 3, 2025
Closed
@josephsavona
Copy link
Member

josephsavona commented Oct 3, 2025

Thanks! I'm fixing up the prettier issue and will land in #34715

@josephsavona josephsavona mentioned this pull request Oct 3, 2025
Merged
josephsavona added a commit that referenced this pull request Oct 3, 2025
@josephsavona @ArnaudBarre
[compiler] Remove @babel/plugin-proposal-private-methods (#34715)
85c427d 
redo of #34458 but fixing up prettier

Co-authored-by: Arnaud Barré <arnaud.barre@carbometrix.com>
github-actions bot pushed a commit that referenced this pull request Oct 3, 2025
@josephsavona
[compiler] Remove @babel/plugin-proposal-private-methods (#34715)
9736c57 
redo of #34458 but fixing up prettier

Co-authored-by: Arnaud Barré <arnaud.barre@carbometrix.com>

DiffTrain build for [85c427d](85c427d)
github-actions bot pushed a commit that referenced this pull request Oct 3, 2025
@josephsavona
[compiler] Remove @babel/plugin-proposal-private-methods (#34715)
2162941 
redo of #34458 but fixing up prettier

Co-authored-by: Arnaud Barré <arnaud.barre@carbometrix.com>

DiffTrain build for [85c427d](85c427d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArnaudBarre @react-sizebot @josephsavona