[react-devtools-shared] Fix URL construction when base URL is invalid #34407
+32
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
new URL(relative, base)and bubbles up, interrupting the DevTools UI.Solution
new URL(sourceMapAt, sourceURL).new URL(sourceMapAt)as an absolute URL.null(no symbolication) rather than throwing.Implementation details
symbolicateSourceinpackages/react-devtools-shared/src/symbolicateSource.jsto handle invalid base URL scenarios without throwing.packages/react-devtools-shared/src/__tests__/utils-test.js:null.Test plan
yarn prettier-checkyarn lincyarn flow dom-nodeyarn test --watchAll=false utils-testyarn test --watchAll=false utils-test inspectedElementRisks and rollout
sourceMappingURL) are unchanged.Affected packages
react-devtools-sharedRelated
Checklist
yarn prettier-checkyarn lincyarn flow dom-nodeSummary
How did you test this change?