-
Notifications
You must be signed in to change notification settings - Fork 49.8k
[compiler] [playground] Show internals toggle #34399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+53
−17
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3cbb055
Remove complex config defaults logic & top-level exports
EugeneChoi4 2bb805a
Refactor code to use less renders
EugeneChoi4 241e5c4
Add sync from config editor to pragma
EugeneChoi4 66bff46
Environment bug fix
EugeneChoi4 f8001e5
Add temporary collapse to config editor (following old format)
EugeneChoi4 6adefd1
Add button to apply config changes
EugeneChoi4 ce65eef
Add toast on successful/failed config parse
EugeneChoi4 94e31de
Add basic validation
EugeneChoi4 51547c8
fix lint
EugeneChoi4 911a27f
Add type checking for PluginOptions
EugeneChoi4 3f2c56d
Merge branch 'main' into compiler-playground-config/3
EugeneChoi4 312d621
lint fix
EugeneChoi4 b5d666d
merge fix
EugeneChoi4 6ebabec
Add toggle switch for showing internals
EugeneChoi4 3716b1a
Fix merge
EugeneChoi4 474ded6
Make tabify more efficient
EugeneChoi4 dab833c
simplify tabify
EugeneChoi4 89b35c5
Don't make config and showInternal fields optional
EugeneChoi4 2a10368
lint fix
EugeneChoi4 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! compiler developers can manually toggle on
show internalswhen using playground for the first time. All later sessions would be able to load this setting from localStorage