Create more realistic containers in DevTools fixture #34296
Merged
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
commented
Aug 25, 2025
| <SuspenseTreeList /> | ||
| </div> | ||
| <div className={styles.ResizeBarWrapper}> | ||
| <div className={styles.ResizeBarWrapper} hidden={treeListHidden}> |
There was a problem hiding this comment.
drive-by fix. I noticed when the sidebars were hidden that you would still get resize cursors without being able to resize anything.
hoxyq
approved these changes
Aug 26, 2025
eps1lon
deleted the
sebbie/08-25-create_more_realistic_containers_in_devtools_fixture
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33516 added a layout switch for which side devtools is attached. Unfortunately, it pushed content outside of the viewport while truncating the content (which can be seen by disabling
contain). This makes it annoying to work on the overall layout in devtools (specifically scrollable areas).This PR preserves the overall fixture layout while making sure the content of devtools and inspected app aren't truncated.
Before:
CleanShot.2025-08-25.at.20.24.57.mp4
After:
CleanShot.2025-08-25.at.20.19.05.mp4