Skip to content

[DevTools] Avoid tearing Suspense store #34294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
+3 −3
Merged

[DevTools] Avoid tearing Suspense store #34294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseRects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function SuspenseRects({

const suspense = store.getSuspenseByID(suspenseID);
if (suspense === null) {
console.warn(`<Element> Could not find suspense node id ${suspenseID}`);
// getSuspenseByID will have already warned
return null;
}

Expand Down
4 changes: 2 additions & 2 deletions packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseTreeContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function SuspenseTreeContextController({children}: Props): React.Node {

useEffect(() => {
const handleSuspenseTreeMutated = () => {
transitionDispatch({
dispatch({
type: 'HANDLE_SUSPENSE_TREE_MUTATION',
});
};
Expand All @@ -91,7 +91,7 @@ function SuspenseTreeContextController({children}: Props): React.Node {
// At the moment, we can treat this as a mutation.
// We don't know which Elements were newly added/removed, but that should be okay in this case.
// It would only impact the search state, which is unlikely to exist yet at this point.
transitionDispatch({
dispatch({
type: 'HANDLE_SUSPENSE_TREE_MUTATION',
});
}
Expand Down
Loading