[compiler] Fix missing dependency in eslint-plugin-react-hooks #34287
+10
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#34176 introduced
@babel/plugin-proposal-private-methods:react/packages/eslint-plugin-react-hooks/src/shared/RunReactCompiler.ts
Line 13 in 63feb94
However, the declared dependencies of
eslint-plugin-react-hooksweren't updated.This mostly worked for package managers that hoist everything but breaks when node_modules are strictly isolated to the set of declared dependencies.
I declared the used dependency in this PR. Could also be possible to use the transform directly.
Fixes
Test plan
packageExtensionsto make the error go away (vercel/next.js@5b2b3a5)