Skip to content

Conversation

@kassens
Copy link
Member

@kassens kassens commented Aug 21, 2025

  • 0.261 required to pull out a constant to preserve refinement
  • 0.259 needed some updated suppressions for hacky stuff

minor fix: to preserve type refinement, we need to extract the value into a constant.
@kassens kassens requested a review from jbrown215 August 21, 2025 18:24
@meta-cla meta-cla bot added the CLA Signed label Aug 21, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 21, 2025
@react-sizebot
Copy link

Comparing: d5586e2...b362bfe

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.18 kB 530.18 kB = 93.39 kB 93.39 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 655.81 kB 655.82 kB = 115.30 kB 115.31 kB
facebook-www/ReactDOM-prod.classic.js = 675.58 kB 675.59 kB = 118.54 kB 118.54 kB
facebook-www/ReactDOM-prod.modern.js = 666.00 kB 666.02 kB = 116.87 kB 116.87 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against b362bfe

@kassens kassens marked this pull request as ready for review August 21, 2025 19:02
@kassens kassens merged commit d73b6f1 into facebook:main Aug 21, 2025
242 checks passed
@kassens kassens deleted the update-flow-261 branch August 21, 2025 19:02
github-actions bot pushed a commit that referenced this pull request Aug 21, 2025
- 0.261 required to pull out a constant to preserve refinement
- 0.259 needed some updated suppressions for hacky stuff

DiffTrain build for [d73b6f1](d73b6f1)
github-actions bot pushed a commit that referenced this pull request Aug 21, 2025
- 0.261 required to pull out a constant to preserve refinement
- 0.259 needed some updated suppressions for hacky stuff

DiffTrain build for [d73b6f1](d73b6f1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants