Skip to content

Conversation

@hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Aug 20, 2025

This fixes the displaying of "rendered by" section if owner stacks contained any native frames. This regressed after #34185, where we added the Suspense boundary for the StackTraceView.

This fails because the Promise that is responsible for symbolication of the source is never getting resolved or rejected.
Previously, we would just throw an Error without sending a corresponding message to the main script, and it would just cache a Promise that is never resolved, hence the Suspense boundary for "rendered by" section is never resolved.

In a separate change, I think we need to update StackTraceView component to display native as location, instead of :0:
Screenshot 2025-08-20 at 00 20 42

@hoxyq hoxyq requested review from eps1lon and sebmarkbage August 20, 2025 09:15
@meta-cla meta-cla bot added the CLA Signed label Aug 20, 2025
Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also just not attempt symbolication on the frontend if the URL is empty?

We can omit locations if the line number is 0.

@hoxyq
Copy link
Contributor Author

hoxyq commented Aug 21, 2025

Shouldn't we also just not attempt symbolication on the frontend if the URL is empty?

Yes, we shouldn't, I can add this separately.

@hoxyq hoxyq merged commit 8120753 into facebook:main Aug 21, 2025
247 checks passed
@hoxyq hoxyq deleted the devtools/fix-always-pending-symbolication-promise branch August 21, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants