[DevTools] Handle fallback unmount in Suspense update path #34199
+94
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
eps1lon
force-pushed
the
sebbie/suspense-fallback-reconcile
branch
from
15bac5c to
d74ed5b
Compare
eps1lon
changed the title
eps1lon
force-pushed
the
sebbie/suspense-fallback-reconcile
branch
from
d74ed5b to
412d937
Compare
eps1lon
force-pushed
the
sebbie/suspense-fallback-reconcile
branch
from
412d937 to
ec57320
Compare
sebmarkbage
approved these changes
Aug 15, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 17, 2025
…34199) DiffTrain build for [8dba931](facebook@8dba931)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Aug 17, 2025
…34199) DiffTrain build for [8dba931](facebook@8dba931)
This was referenced Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we unmount a fallback, we reconciled it in the context of the current Suspense instead of parent Suspense. But since we mounted it in the context of the parent Suspense, we also need to unmount it in the context of the parent Suspense.