Skip to content

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Aug 4, 2025

Stacked on #34101.

This adds a badge to owners if they are different from the currently selected component's environment.

Screenshot 2025-08-04 at 5 15 02 PM

We also add one to the end of stack traces if the stack trace has a different environment than the owner which can happen when you call a function (without rendering a component) into a third party environment but the owner component was in the first party.

One awkward thing is that Suspense boundaries are always in the client environment so their Server Components are always badged.

@sebmarkbage sebmarkbage requested a review from eps1lon August 4, 2025 21:17
@meta-cla meta-cla bot added the CLA Signed label Aug 4, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Aug 4, 2025
This could happen if you execute a cached function inside one component
environment but it's called from a parent component in the parent environment.

Such as calling a cached function from a server component.
@sebmarkbage sebmarkbage merged commit 738aebd into facebook:main Aug 7, 2025
241 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants