[Flight] Support classes in renderDebugModel #33590
Open
+140
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
Such as if the body contains native code.
sebmarkbage
force-pushed
the
debugclasses
branch
from
e57882c to
a1dc769
Compare
unstubbable
approved these changes
Jun 22, 2025
| return name.replace(/^\[object (.*)\]$/, function (m, p0) { | ||
| return p0; | ||
| }); | ||
| return name.slice(8, name.length - 1); |
There was a problem hiding this comment.
With the regex now gone, a comment explaining the magic 8 would be nice, e.g.:
Suggested change
| return name.slice(8, name.length - 1); | |
| // Extract 'Object' from '[object Object]': | |
| return name.slice(8, name.length - 1); |
| for (const propName in object) { | ||
| if (hasOwnProperty.call(value, propName) || isGetter(proto, propName)) { | ||
| // We intentionally invoke getters on the prototype to read any enumerable getters. | ||
| instanceDescription[propName] = object[propName]; |
There was a problem hiding this comment.
I'm a bit concerned that this might trigger unwanted side effects, like the getters on the "exotic" promises in Next.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds better support for serializing class instances as Debug values.
It adds a new marker on the object
{ "": "$P...", ... }which indicates which constructor's prototype to use for this object's prototype. It doesn't encode arbitrary prototypes and it doesn't encode any of the properties on the prototype. It might get some of the properties from the prototype by virtue oftoStringon aclassconstructor will include the whole class's body.This will ensure that the instance gets the right name in logs.
Additionally, this now also invokes getters if they're enumerable on the prototype. This lets us reify values that can only be read from native classes.