Skip to content

[Flight] Add a cached 3rd-party component to the Flight fixture #33443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

unstubbable
Copy link
Collaborator

@unstubbable unstubbable commented Jun 5, 2025

This should allow us to visualize what #33438 is trying to convey.

An uncached 3rd-party component is displayed like this in the dev tools:

Screenshot 2025-06-05 at 12 57 32

However, when the component is restored from a cache, it looks like this:

Screenshot 2025-06-05 at 12 56 56

The Server Components ⚛ track is missing completely here, and the Loading profile... phase also took way longer than without caching the 3rd-party component.

On main, the Server Components ⚛ track is not missing:

Screenshot 2025-06-05 at 14 31 20

The cached 3rd-party component starts before the current render, and is also not excluded here, which is of course expected without #33438.

@unstubbable unstubbable changed the title Flight fixture 3rd party [Flight] Add a cached 3rd-party component to the Flight fixture Jun 5, 2025
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 5, 2025
@react-sizebot
Copy link

react-sizebot commented Jun 5, 2025

Comparing: 93f1668...7fc7f64

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.07 kB 530.07 kB = 93.57 kB 93.57 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.16 kB 651.16 kB = 114.70 kB 114.70 kB
facebook-www/ReactDOM-prod.classic.js = 676.11 kB 676.11 kB = 118.97 kB 118.97 kB
facebook-www/ReactDOM-prod.modern.js = 666.39 kB 666.39 kB = 117.36 kB 117.36 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 7fc7f64

This should allow us to visualize what facebook#33438 is trying to convey.
@unstubbable unstubbable force-pushed the flight-fixture-3rd-party branch from b4d5d97 to 7fc7f64 Compare June 5, 2025 15:10
@unstubbable unstubbable marked this pull request as ready for review June 5, 2025 15:12
@unstubbable unstubbable merged commit b4477d3 into facebook:main Jun 5, 2025
244 checks passed
@unstubbable unstubbable deleted the flight-fixture-3rd-party branch June 5, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants