Cleanup props diffing experiments #33381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kassens
approved these changes
May 30, 2025
| @@ -33,8 +33,6 @@ export const { | |||
| retryLaneExpirationMs, | |||
| syncLaneExpirationMs, | |||
| transitionLaneExpirationMs, | |||
| enableFastAddPropertiesInDiffing, | |||
| enableViewTransition, | |||
There was a problem hiding this comment.
Keep enableViewTransition, probably a rebase merge error since I had it briefly removed.
javache
force-pushed
the
rn-cleanup-payload-diffing
branch
from
db1429f to
4113c25
Compare
|
Comparing: 14094f8...4113c25 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
May 30, 2025
## Summary We completed testing on these internally, so can cleanup the separate fast and slow paths and remove the `enableShallowPropDiffing` flag which we're not pursuing. ## How did you test this change? ``` yarn test ReactNativeAttributePayloadFabric ``` DiffTrain build for [8b55eb4](facebook@8b55eb4)
This was referenced Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We completed testing on these internally, so can cleanup the separate fast and slow paths and remove the
enableShallowPropDiffingflag which we're not pursuing.How did you test this change?