-
Notifications
You must be signed in to change notification settings - Fork 49.8k
Add component names to ViewTransition autoName in DEV #33092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Comparing: e5a8de8...09459d3 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
kassens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there are issues in generating different ids in DEV. I think in the past I've seen some issues filed where DEV and prod where mixed between server and client.
packages/react-reconciler/src/ReactFiberViewTransitionComponent.js
Outdated
Show resolved
Hide resolved
|
The difference between hydrating/client animation names was removed in #33094 so I don't think we need to be concerned about a mismatch in the current implementation. |
Hardanish-Singh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
When debugging ViewTransition, it can be difficult to use the Animations dev tools if you have multiple active ViewTransitions without specific names. We can make this a bit easier by adding the name of the owner component to the generated name in DEV. At least then you can have a high level idea of where the active animations are coming from and if they're relevant to the one you're debugging.
This implementation shortens the name, replaced invalid characters, and surrounds it in underscores as part of the existing generated name. I'm not tied to the specific replacement symbol or wrapper characters. Also if we can't get an owner component name, we could just leave it out instead of supplying the "unknown" string.