Skip to content

Rename Suspense unstable_name to name #33014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2025
Merged

Rename Suspense unstable_name to name #33014

merged 1 commit into from
Apr 24, 2025

Conversation

sebmarkbage
Copy link
Collaborator

This was only used by Transition Tracing which isn't really used anywhere.

However, we want to start using it for other DevTools.

@sebmarkbage
Rename Suspense unstable_name to name
0db3624 
This was only used by Transition Tracing which isn't really used anywhere.

However, we want to start using it for other DevTools.
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Apr 24, 2025
@react-sizebot
Copy link

Comparing: bb74190...0db3624

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 527.72 kB 518.75 kB = 93.07 kB 92.26 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 633.34 kB 624.61 kB = 111.25 kB 110.44 kB
facebook-www/ReactDOM-prod.classic.js = 671.16 kB 657.98 kB = 117.72 kB 115.98 kB
facebook-www/ReactDOM-prod.modern.js = 661.44 kB 648.26 kB = 116.16 kB 114.43 kB
facebook-www/ReactDOM-profiling.classic.js = 744.53 kB 729.41 kB = 127.79 kB 125.97 kB
facebook-www/ReactDOM-profiling.modern.js = 736.48 kB 721.36 kB = 126.48 kB 124.67 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js = 402.14 kB 393.26 kB = 64.81 kB 63.96 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js = 402.11 kB 393.24 kB = 64.78 kB 63.94 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js = 431.36 kB 421.66 kB = 68.80 kB 67.82 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js = 431.33 kB 421.64 kB = 68.78 kB 67.79 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.development.js = 7.22 kB 6.92 kB = 1.69 kB 1.66 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js = 7.22 kB 6.92 kB = 1.69 kB 1.66 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js = 7.22 kB 6.92 kB = 1.69 kB 1.66 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.production.js = 6.54 kB 6.26 kB = 1.69 kB 1.66 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.production.js = 6.54 kB 6.26 kB = 1.69 kB 1.66 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.production.js = 6.54 kB 6.26 kB = 1.69 kB 1.66 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server/cjs/react-server-flight.production.js = 62.91 kB 62.78 kB = 12.52 kB 12.51 kB
oss-stable-semver/react-server/cjs/react-server-flight.production.js = 57.95 kB 57.82 kB = 11.65 kB 11.64 kB
oss-stable/react-server/cjs/react-server-flight.production.js = 57.95 kB 57.82 kB = 11.65 kB 11.64 kB
react-native/implementations/ReactNativeRenderer-dev.fb.js = 676.47 kB 669.60 kB = 109.79 kB 109.12 kB
react-native/implementations/ReactFabric-dev.fb.js = 670.36 kB 663.50 kB = 108.80 kB 108.16 kB
react-native/implementations/ReactNativeRenderer-dev.js = 660.31 kB 653.45 kB = 107.04 kB 106.40 kB
react-native/implementations/ReactFabric-dev.js = 651.33 kB 644.47 kB = 105.63 kB 105.02 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js = 988.37 kB 977.48 kB = 165.84 kB 164.62 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js = 988.25 kB 977.35 kB = 165.81 kB 164.59 kB
facebook-www/ReactDOMTesting-dev.classic.js = 1,226.98 kB 1,213.37 kB = 203.73 kB 202.40 kB
facebook-www/ReactDOMTesting-dev.modern.js = 1,217.84 kB 1,204.23 kB = 202.02 kB 200.71 kB
oss-stable/react-dom/cjs/react-dom-client.development.js = 971.93 kB 961.04 kB = 162.99 kB 161.78 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js = 971.81 kB 960.91 kB = 162.97 kB 161.75 kB
facebook-www/ReactDOM-dev.classic.js = 1,210.45 kB 1,196.84 kB = 200.02 kB 198.65 kB
facebook-www/ReactDOM-dev.modern.js = 1,201.31 kB 1,187.70 kB = 198.25 kB 196.89 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js = 600.73 kB 593.85 kB = 96.44 kB 95.77 kB
facebook-www/ReactART-dev.classic.js = 724.08 kB 715.51 kB = 112.91 kB 112.12 kB
facebook-www/ReactART-dev.modern.js = 714.58 kB 706.02 kB = 111.18 kB 110.27 kB
facebook-www/ReactTestRenderer-dev.classic.js = 587.47 kB 580.42 kB = 94.90 kB 94.16 kB
facebook-www/ReactTestRenderer-dev.modern.js = 587.46 kB 580.41 kB = 94.90 kB 94.16 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js = 569.52 kB 562.47 kB = 91.85 kB 91.05 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 569.47 kB 562.42 kB = 91.84 kB 91.04 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js = 569.44 kB 562.39 kB = 91.83 kB 91.03 kB
oss-stable/react-art/cjs/react-art.development.js = 570.48 kB 563.41 kB = 91.09 kB 90.33 kB
oss-stable-semver/react-art/cjs/react-art.development.js = 570.40 kB 563.34 kB = 91.07 kB 90.30 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,164.92 kB 1,150.20 kB = 194.66 kB 192.88 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js = 1,164.77 kB 1,150.05 kB = 193.81 kB 192.04 kB
oss-experimental/react-art/cjs/react-art.development.js = 661.18 kB 652.79 kB = 104.24 kB 103.46 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js = 1,148.38 kB 1,133.66 kB = 190.96 kB 189.20 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js = 1,024.04 kB 1,010.72 kB = 171.72 kB 169.90 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js = 1,007.71 kB 994.39 kB = 168.87 kB 167.07 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 647.75 kB 639.02 kB = 114.84 kB 114.02 kB
facebook-www/ReactART-prod.classic.js = 388.33 kB 383.10 kB = 64.99 kB 64.44 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 633.34 kB 624.61 kB = 111.25 kB 110.44 kB
facebook-www/ReactART-prod.modern.js = 378.35 kB 373.11 kB = 63.32 kB 62.81 kB
react-native/implementations/ReactNativeRenderer-profiling.fb.js = 413.74 kB 407.91 kB = 70.64 kB 70.11 kB
react-native/implementations/ReactFabric-profiling.fb.js = 409.97 kB 404.16 kB = 70.01 kB 69.53 kB
react-native/implementations/ReactNativeRenderer-prod.fb.js = 385.62 kB 380.15 kB = 66.54 kB 66.06 kB
react-native/implementations/ReactFabric-prod.fb.js = 381.79 kB 376.33 kB = 65.90 kB 65.38 kB
react-native/implementations/ReactNativeRenderer-profiling.js = 399.80 kB 393.93 kB = 68.01 kB 67.46 kB
react-native/implementations/ReactNativeRenderer-prod.js = 371.85 kB 366.35 kB = 63.93 kB 63.41 kB
oss-experimental/react-art/cjs/react-art.production.js = 347.64 kB 342.46 kB = 58.63 kB 58.15 kB
react-native/implementations/ReactFabric-profiling.js = 392.26 kB 386.38 kB = 66.79 kB 66.25 kB
react-native/implementations/ReactFabric-prod.js = 364.35 kB 358.85 kB = 62.82 kB 62.34 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js = 699.33 kB 688.76 kB = 121.10 kB 120.19 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 789.25 kB 776.71 kB = 123.10 kB 121.99 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js = 360.90 kB 355.07 kB = 61.67 kB 61.13 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js = 557.42 kB 548.39 kB = 98.18 kB 97.25 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js = 336.14 kB 330.67 kB = 58.25 kB 57.74 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js = 551.91 kB 542.88 kB = 97.09 kB 96.17 kB
facebook-www/ReactReconciler-dev.classic.js = 840.43 kB 826.38 kB = 130.59 kB 129.31 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js = 586.08 kB 576.25 kB = 102.23 kB 101.27 kB
facebook-www/ReactReconciler-dev.modern.js = 831.22 kB 817.17 kB = 128.86 kB 127.58 kB
oss-stable/react-art/cjs/react-art.production.js = 306.75 kB 301.55 kB = 51.78 kB 51.30 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js = 580.14 kB 570.30 kB = 101.07 kB 100.11 kB
oss-stable-semver/react-art/cjs/react-art.production.js = 306.67 kB 301.47 kB = 51.76 kB 51.27 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 527.72 kB 518.75 kB = 93.07 kB 92.26 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js = 527.59 kB 518.63 kB = 93.04 kB 92.23 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js = 561.37 kB 551.65 kB = 98.03 kB 97.16 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js = 561.25 kB 551.53 kB = 98.00 kB 97.13 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js = 663.84 kB 652.28 kB = 105.02 kB 103.93 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js = 663.81 kB 652.26 kB = 104.99 kB 103.91 kB
facebook-www/ReactReconciler-prod.classic.js = 508.46 kB 499.50 kB = 81.13 kB 80.18 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js = 319.35 kB 313.67 kB = 55.45 kB 54.95 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js = 319.17 kB 313.49 kB = 55.41 kB 54.91 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js = 319.10 kB 313.42 kB = 55.39 kB 54.89 kB
facebook-www/ReactReconciler-prod.modern.js = 498.15 kB 489.20 kB = 79.51 kB 78.59 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 474.73 kB 466.11 kB = 75.80 kB 74.87 kB
facebook-www/ReactDOMTesting-prod.classic.js = 685.56 kB 672.38 kB = 121.39 kB 119.66 kB
facebook-www/ReactDOMTesting-prod.modern.js = 675.84 kB 662.66 kB = 119.83 kB 118.05 kB
facebook-www/ReactDOM-prod.classic.js = 671.16 kB 657.98 kB = 117.72 kB 115.98 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 538.69 kB 528.10 kB = 84.68 kB 83.67 kB
facebook-www/ReactDOM-prod.modern.js = 661.44 kB 648.26 kB = 116.16 kB 114.43 kB
facebook-www/ReactDOM-profiling.classic.js = 744.53 kB 729.41 kB = 127.79 kB 125.97 kB
facebook-www/ReactDOM-profiling.modern.js = 736.48 kB 721.36 kB = 126.48 kB 124.67 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js = 402.14 kB 393.26 kB = 64.81 kB 63.96 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js = 402.11 kB 393.24 kB = 64.78 kB 63.94 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js = 431.36 kB 421.66 kB = 68.80 kB 67.82 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js = 431.33 kB 421.64 kB = 68.78 kB 67.79 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.development.js = 7.22 kB 6.92 kB = 1.69 kB 1.66 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js = 7.22 kB 6.92 kB = 1.69 kB 1.66 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js = 7.22 kB 6.92 kB = 1.69 kB 1.66 kB
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.production.js = 6.54 kB 6.26 kB = 1.69 kB 1.66 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.production.js = 6.54 kB 6.26 kB = 1.69 kB 1.66 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.production.js = 6.54 kB 6.26 kB = 1.69 kB 1.66 kB

Generated by 🚫 dangerJS against 0db3624

@sebmarkbage sebmarkbage merged commit 693803a into facebook:main Apr 24, 2025
245 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 24, 2025
@sebmarkbage
Rename Suspense unstable_name to name (#33014)
7c12c71 
This was only used by Transition Tracing which isn't really used
anywhere.

However, we want to start using it for other DevTools.

DiffTrain build for [693803a](693803a)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Apr 25, 2025
@pull
Rename Suspense unstable_name to name (facebook#33014)
091be8d 
This was only used by Transition Tracing which isn't really used
anywhere.

However, we want to start using it for other DevTools.

DiffTrain build for [693803a](facebook@693803a)
This was referenced Apr 25, 2025
Closed
Closed
Merged
@eps1lon eps1lon mentioned this pull request May 5, 2025
Merged
This was referenced May 5, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced May 12, 2025
Merged
Merged
Merged
Merged
Closed
This was referenced May 19, 2025
Merged
Merged
Closed
@vercel-release-bot vercel-release-bot mentioned this pull request May 21, 2025
Closed
@eps1lon eps1lon mentioned this pull request Jun 7, 2025
Draft
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackpope jackpope jackpope approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

@hoxyq hoxyq Awaiting requested review from hoxyq

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @jackpope @facebook-github-bot