[Fizz] Add Owner Stacks when render is aborted #32735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
changed the title
github-actions
bot
added
the
React Core Team
|
Comparing: 526dd34...1fa57c6 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
eps1lon
force-pushed
the
sebbie/fizz-abort-ownerstack
branch
from
0114c88 to
c819e57
Compare
eps1lon
force-pushed
the
sebbie/fizz-abort-ownerstack
branch
2 times, most recently
from
404c603 to
8c0c76a
Compare
eps1lon
commented
Mar 25, 2025
| @@ -311,6 +311,7 @@ function render(children: React$Element<any>, options?: Options): Destination { | |||
| children, | |||
| null, | |||
| null, | |||
| null, | |||
There was a problem hiding this comment.
Otherwise the optional on* callbacks were not lined up correctly.
eps1lon
commented
Mar 25, 2025
| '\n in Component (at **)' + '\n in App (at **)', | ||
| ); | ||
| expect(normalizeCodeLocInfo(ownerStack)).toEqual( | ||
| __DEV__ ? '\n in App (at **)' : null, |
There was a problem hiding this comment.
Ideally, the stack would start at Component
sebmarkbage
approved these changes
Jun 2, 2025
eps1lon
force-pushed
the
sebbie/fizz-abort-ownerstack
branch
from
8c0c76a to
1fa57c6
Compare
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jun 2, 2025
DiffTrain build for [4a1f290](facebook@4a1f290)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Jun 2, 2025
DiffTrain build for [4a1f290](facebook@4a1f290)
This was referenced Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
captureOwnerStacknow returns the corresponding owner stack to the parent stack when we abort a Fizz render.How did you test this change?