[compiler][optim] Add map and set constructors #32697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
React Core Team
Member
|
Yesssssss |
josephsavona
approved these changes
Mar 21, 2025
Member
josephsavona
left a comment
josephsavona
left a comment
There was a problem hiding this comment.
Repeating my comment: yessss i've wanted to have typing/effects for constructors and Map/Set for a long time. So glad you're adding this. A few small comments but overall looks great
| [ | ||
| 'has', | ||
| addFunction(BUILTIN_SHAPES, [], { | ||
| positionalParams: [], |
| * forEach(callbackFn) | ||
| * forEach(callbackFn, thisArg) | ||
| */ | ||
| 'forEach', |
Member
There was a problem hiding this comment.
this mutates only if the arguments are mutable, right?
| }), | ||
| ], | ||
| /** | ||
| * Iteraturs |
| ], | ||
| ['size', PRIMITIVE_TYPE], | ||
| [ | ||
| 'forEach', |
| if (tB.kind === 'Function' && tA.kind === 'Function') { | ||
| this.unify(tA.return, tB.return); | ||
| return; | ||
| if (tA.isConstructor === tB.isConstructor) { |
Member
There was a problem hiding this comment.
nit: could collapse these ifs
mofeiZ
added a commit
that referenced
this pull request
Mar 24, 2025
…perands are globals (#32695) Globals, module locals, and other locally defined functions may mutate their arguments. See test fixtures for details --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32695). * #32698 * #32697 * #32696 * __->__ #32695
mofeiZ
added a commit
that referenced
this pull request
Mar 24, 2025
…handling (#32696) Simplify InferReferenceEffect function signature matching logic for next PRs in stack --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32696). * #32698 * #32697 * __->__ #32696 * #32695
* Adds `isConstructor: boolean` to `FunctionType`. With this PR, each typed function can either be a constructor (currently only known globals) or non constructor. Alternatively, we prefer to encode polymorphic types / effects (and match the closest subtype) * Add Map and Set globals + built-ins
github-actions bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
…handling (#32696) Simplify InferReferenceEffect function signature matching logic for next PRs in stack --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32696). * #32698 * #32697 * __->__ #32696 * #32695 DiffTrain build for [45463ab](45463ab)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
* Adds `isConstructor: boolean` to `FunctionType`. With this PR, each typed function can either be a constructor (currently only known globals) or non constructor. Alternatively, we prefer to encode polymorphic types / effects (and match the closest subtype) * Add Map and Set globals + built-ins --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32697). * #32698 * __->__ #32697 DiffTrain build for [a8e503d](a8e503d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
isConstructor: booleantoFunctionType. With this PR, each typed function can either be a constructor (currently only known globals) or non constructor. Alternatively, we prefer to encode polymorphic types / effects (and match the closest subtype)Add Map and Set globals + built-ins
Stack created with Sapling. Best reviewed with ReviewStack.