Skip to content

Conversation

@poteto
Copy link
Member

@poteto poteto commented Mar 13, 2025

Now that the compiler lint rule is merged into eslint-plugin-react-hooks, we also need to update our caches so compiler dependencies are also cached. This should fix the CI walltime regression we are now seeing.

Stack created with Sapling. Best reviewed with ReviewStack.

@react-sizebot
Copy link

react-sizebot commented Mar 13, 2025

Comparing: 7939d92fcc95ad5ee719c38272eaef14a3750fc0...80d49ef689b97568dbcc053e7be1ae84c72a77b4

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 518.75 kB 518.75 kB = 92.47 kB 92.47 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 591.76 kB 591.76 kB = 105.36 kB 105.36 kB
facebook-www/ReactDOM-prod.classic.js = 652.39 kB 652.39 kB = 114.72 kB 114.72 kB
facebook-www/ReactDOM-prod.modern.js = 642.71 kB 642.71 kB = 113.15 kB 113.15 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against a423f95

Now that the compiler lint rule is merged into eslint-plugin-react-hooks, we also need to update our caches so compiler dependencies are also cached. This should fix the CI walltime regression we are now seeing.
@poteto poteto merged commit 6733870 into main Mar 14, 2025
194 checks passed
@poteto poteto deleted the pr32603 branch March 14, 2025 00:31
poteto added a commit that referenced this pull request Mar 14, 2025
poteto added a commit that referenced this pull request Mar 14, 2025
poteto added a commit that referenced this pull request Mar 14, 2025
This reverts commit 6733870.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32607).
* #32609
* #32608
* __->__ #32607
github-actions bot pushed a commit that referenced this pull request Mar 14, 2025
This reverts commit 6733870.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32607).
* #32609
* #32608
* __->__ #32607

DiffTrain build for [5200721](5200721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants