Skip to content

Conversation

@sebmarkbage
Copy link
Contributor

Setting the animation's currentTime causes a quirk where the transition can end up off by a bit and the end state can be slightly off the end time.

However, I realized that we don't have to because if we just set the direction in the animate() call directly the Safari bug goes away.

@sebmarkbage sebmarkbage requested a review from jackpope March 5, 2025 03:29
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Mar 5, 2025
@react-sizebot
Copy link

Comparing: e9252bcdccf7f8f691081e4d48ca47657bc723f9...82f8e37cab800783952c84e2bbc23c4f508e145f

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 518.43 kB 518.43 kB = 92.44 kB 92.44 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 589.24 kB 589.19 kB = 104.93 kB 104.91 kB
facebook-www/ReactDOM-prod.classic.js = 642.65 kB 642.65 kB = 113.00 kB 113.00 kB
facebook-www/ReactDOM-prod.modern.js = 632.96 kB 632.96 kB = 111.44 kB 111.44 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 012a5d5

@sebmarkbage sebmarkbage merged commit e03ac20 into facebook:main Mar 5, 2025
194 checks passed
jbrown215 added a commit to jbrown215/react that referenced this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants