Skip to content

Conversation

@SamChou19815
Copy link
Contributor

Summary

Flow will remove these types from global library definition soon. This PR replaces them in the ReactNativeTypes first, because this file will be synced to the react-native repo.

How did you test this change?

flow

@react-sizebot
Copy link

react-sizebot commented Feb 7, 2025

Comparing: fcb4e0f...ceffcdd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.11% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 515.71 kB 515.71 kB = 92.09 kB 92.09 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 562.25 kB 562.25 kB = 100.08 kB 100.08 kB
facebook-www/ReactDOM-prod.classic.js = 636.70 kB 636.70 kB = 112.08 kB 112.08 kB
facebook-www/ReactDOM-prod.modern.js = 627.02 kB 627.02 kB = 110.49 kB 110.50 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
react-native/shims/ReactNativeTypes.js +1.83% 8.57 kB 8.73 kB +2.85% 2.28 kB 2.35 kB

Generated by 🚫 dangerJS against f28d439

@SamChou19815 SamChou19815 marked this pull request as draft February 7, 2025 18:58
@SamChou19815 SamChou19815 force-pushed the remove-global-react-types branch from 1f77ae4 to aeb95e4 Compare February 7, 2025 19:03
@SamChou19815 SamChou19815 marked this pull request as ready for review February 7, 2025 19:11
Copy link
Contributor

@jbrown215 jbrown215 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@SamChou19815 SamChou19815 merged commit 70f1d76 into main Feb 20, 2025
194 checks passed
@poteto poteto deleted the remove-global-react-types branch March 11, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants