Skip to content

[internal] fix console patch, add RN #32075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

rickhanlonii
Copy link
Member

The forking for shared/ReactFeatureFlags doesn't work in the console patches. Since they're already forked, we can import the internal ReactFeatureFlags files directly.

Would have caught this in testing a PR sync, but the PR syncs are broken right now.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 15, 2025
@react-sizebot
Copy link

Comparing: b158439...8587abe

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 514.24 kB 514.24 kB = 91.74 kB 91.73 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 556.18 kB 556.18 kB = 98.72 kB 98.72 kB
facebook-www/ReactDOM-prod.classic.js = 595.79 kB 595.79 kB = 104.85 kB 104.85 kB
facebook-www/ReactDOM-prod.modern.js = 586.21 kB 586.21 kB = 103.30 kB 103.30 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-dev.js +29.88% 1.39 kB 1.80 kB +16.95% 0.71 kB 0.84 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js +2.42% 17.15 kB 17.57 kB +3.02% 3.78 kB 3.89 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-dev.js +29.88% 1.39 kB 1.80 kB +16.95% 0.71 kB 0.84 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js +2.42% 17.15 kB 17.57 kB +3.02% 3.78 kB 3.89 kB
facebook-react-native/react/cjs/JSXDEVRuntime-dev.js +1.47% 26.13 kB 26.51 kB +1.39% 6.20 kB 6.29 kB
facebook-react-native/react/cjs/JSXRuntime-dev.js +1.46% 26.39 kB 26.77 kB +1.40% 6.22 kB 6.31 kB
facebook-react-native/react/cjs/React-dev.js +0.75% 66.17 kB 66.67 kB +0.78% 14.56 kB 14.68 kB
facebook-www/ReactReconcilerConstants-dev.classic.js = 0.64 kB 0.63 kB = 0.35 kB 0.35 kB
facebook-www/ReactReconcilerConstants-dev.modern.js = 0.64 kB 0.63 kB = 0.35 kB 0.35 kB

Generated by 🚫 dangerJS against 23163a2

@rickhanlonii rickhanlonii merged commit 43d18bc into facebook:main Jan 15, 2025
186 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
The forking for `shared/ReactFeatureFlags` doesn't work in the console
patches. Since they're already forked, we can import the internal
ReactFeatureFlags files directly.

Would have caught this in testing a PR sync, but the PR syncs are broken
right now.

DiffTrain build for [43d18bc](43d18bc)
github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
The forking for `shared/ReactFeatureFlags` doesn't work in the console
patches. Since they're already forked, we can import the internal
ReactFeatureFlags files directly.

Would have caught this in testing a PR sync, but the PR syncs are broken
right now.

DiffTrain build for [43d18bc](43d18bc)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Jan 15, 2025
The forking for `shared/ReactFeatureFlags` doesn't work in the console
patches. Since they're already forked, we can import the internal
ReactFeatureFlags files directly.

Would have caught this in testing a PR sync, but the PR syncs are broken
right now.

DiffTrain build for [43d18bc](facebook@43d18bc)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Jan 15, 2025
The forking for `shared/ReactFeatureFlags` doesn't work in the console
patches. Since they're already forked, we can import the internal
ReactFeatureFlags files directly.

Would have caught this in testing a PR sync, but the PR syncs are broken
right now.

DiffTrain build for [43d18bc](facebook@43d18bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants