Skip to content

react-hooks/rules-of-hooks: detect issues in class properties #31823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

mjesun
Copy link
Contributor

@mjesun mjesun commented Dec 17, 2024

Summary

This is a revival of the PR initially added by @ecraig12345 (#27435) to fix a recent change in the AST used by ESLint to represent class properties.

How did you test this change?

Ran yarn test packages/eslint-plugin-react-hooks and yarn test --prod packages/eslint-plugin-react-hooks.

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 10:50am

@facebook-github-bot
Copy link
Contributor

Hi @mjesun!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@mjesun
Copy link
Contributor Author

mjesun commented Dec 18, 2024

@eps1lon could we merge this one which is rebased from the one that was originally created?

@rubennorte rubennorte requested a review from eps1lon December 20, 2024 10:39
@react-sizebot
Copy link

react-sizebot commented Dec 20, 2024

The size diff is too large to display in a single comment. The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.

Generated by 🚫 dangerJS against 39d9aa1

Copy link
Collaborator

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eps1lon eps1lon merged commit 301a18a into facebook:main Jan 6, 2025
187 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
Co-authored-by: Elizabeth Craig <elcraig@microsoft.com>

DiffTrain build for [301a18a](301a18a)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Jan 6, 2025
…ok#31823)

Co-authored-by: Elizabeth Craig <elcraig@microsoft.com>

DiffTrain build for [301a18a](facebook@301a18a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants