-
Notifications
You must be signed in to change notification settings - Fork 49k
react-hooks/rules-of-hooks: detect issues in class properties #31823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-hooks/rules-of-hooks: detect issues in class properties #31823
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @mjesun! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
c072dd7
to
97b4876
Compare
@eps1lon could we merge this one which is rebased from the one that was originally created? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…ok#31823) Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> DiffTrain build for [301a18a](facebook@301a18a)
Summary
This is a revival of the PR initially added by @ecraig12345 (#27435) to fix a recent change in the AST used by ESLint to represent class properties.
How did you test this change?
Ran
yarn test packages/eslint-plugin-react-hooks
andyarn test --prod packages/eslint-plugin-react-hooks
.