-
Notifications
You must be signed in to change notification settings - Fork 50.6k
fix(compiler): add tanstack table and virtual to known incompat libraries #31820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
bump |
|
Thanks for the PR -- @poteto do you have any context on TanStack? Reading through the linked issues, |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
bump |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
We plan to remove the health check script in favor of using ESLint to check the health of a codebase, so we don’t plan to land the change as-is. Instead, we’ve added a way to teach the compiler about incompatible libraries so that it can automatically skip compilation of code that uses them. We already include TanStack table in that list, which you can see here: react/compiler/packages/babel-plugin-react-compiler/src/HIR/DefaultModuleTypeProvider.ts Line 71 in 47664de
We’re open to PRs that extend the list of unsupported libraries using the same approach, ie adding entries to that file. For more background on the new approach see #34027 |
|
@josephsavona thanks, here's a PR #34493 |
…ries (#34493) Replaces #31820. #34027 added a check for `@tanstack/react-table`, but not `@tanstack/react-virtual`. In our testing `@tanstack/react-virtual`'s `useVirtualizer` returns functions that cannot be memoized, [this is also documented in the community](TanStack/virtual#736 (comment)).
…ries (#34493) Replaces #31820. #34027 added a check for `@tanstack/react-table`, but not `@tanstack/react-virtual`. In our testing `@tanstack/react-virtual`'s `useVirtualizer` returns functions that cannot be memoized, [this is also documented in the community](TanStack/virtual#736 (comment)). DiffTrain build for [e12b0bd](e12b0bd)
…ries (#34493) Replaces #31820. #34027 added a check for `@tanstack/react-table`, but not `@tanstack/react-virtual`. In our testing `@tanstack/react-virtual`'s `useVirtualizer` returns functions that cannot be memoized, [this is also documented in the community](TanStack/virtual#736 (comment)). DiffTrain build for [e12b0bd](e12b0bd)
Summary
In our testing with the compiler the
@tanstack/react-tableand@tanstack/react-virtualboth needuse no memodirectives to avoid breakage.It seems to be a known issue:
It can save someone quite some time of debugging if the health check can flag these :)