Skip to content

Conversation

@stipsan
Copy link
Contributor

@stipsan stipsan commented Dec 17, 2024

Summary

In our testing with the compiler the @tanstack/react-table and @tanstack/react-virtual both need use no memo directives to avoid breakage.
It seems to be a known issue:

It can save someone quite some time of debugging if the health check can flag these :)

@vercel
Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 1:54pm

@stipsan stipsan changed the title fix(compiler): add tanstack table and virutal to known incompat libraries fix(compiler): add tanstack table and virtual to known incompat libraries Dec 17, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Mar 17, 2025
@stipsan
Copy link
Contributor Author

stipsan commented Mar 17, 2025

bump

@mofeiZ
Copy link
Contributor

mofeiZ commented Mar 17, 2025

Thanks for the PR -- @poteto do you have any context on TanStack? Reading through the linked issues, TanStack/table at least won't be compatible with react compiler in the near future.

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Mar 17, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Jun 15, 2025
@stipsan
Copy link
Contributor Author

stipsan commented Jun 16, 2025

bump

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Jun 16, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Sep 14, 2025
@josephsavona
Copy link
Member

We plan to remove the health check script in favor of using ESLint to check the health of a codebase, so we don’t plan to land the change as-is.

Instead, we’ve added a way to teach the compiler about incompatible libraries so that it can automatically skip compilation of code that uses them. We already include TanStack table in that list, which you can see here:

We’re open to PRs that extend the list of unsupported libraries using the same approach, ie adding entries to that file. For more background on the new approach see #34027

@stipsan
Copy link
Contributor Author

stipsan commented Sep 15, 2025

@josephsavona thanks, here's a PR #34493

@stipsan stipsan closed this Sep 15, 2025
@stipsan stipsan deleted the patch-1 branch September 15, 2025 13:29
josephsavona pushed a commit that referenced this pull request Sep 15, 2025
…ries (#34493)

Replaces #31820. #34027 added a check for `@tanstack/react-table`, but
not `@tanstack/react-virtual`.
In our testing `@tanstack/react-virtual`'s `useVirtualizer` returns
functions that cannot be memoized, [this is also documented in the
community](TanStack/virtual#736 (comment)).
github-actions bot pushed a commit that referenced this pull request Sep 15, 2025
…ries (#34493)

Replaces #31820. #34027 added a check for `@tanstack/react-table`, but
not `@tanstack/react-virtual`.
In our testing `@tanstack/react-virtual`'s `useVirtualizer` returns
functions that cannot be memoized, [this is also documented in the
community](TanStack/virtual#736 (comment)).

DiffTrain build for [e12b0bd](e12b0bd)
github-actions bot pushed a commit that referenced this pull request Sep 15, 2025
…ries (#34493)

Replaces #31820. #34027 added a check for `@tanstack/react-table`, but
not `@tanstack/react-virtual`.
In our testing `@tanstack/react-virtual`'s `useVirtualizer` returns
functions that cannot be memoized, [this is also documented in the
community](TanStack/virtual#736 (comment)).

DiffTrain build for [e12b0bd](e12b0bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants