Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container #3176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimfb
changed the title
jimfb
force-pushed
the
webcomponent-to-vendor-thirdparty
branch
from
6d2f283 to
5f605cc
Compare
| @@ -144,4 +151,25 @@ describe('ReactMount', function() { | |||
| ReactMount.render(<div />, container); | |||
| expect(console.warn.mock.calls.length).toBe(0); | |||
| }); | |||
|
|
|||
| ;(WebComponents === undefined ? xit : it) | |||
There was a problem hiding this comment.
What's with the ; in this case? (just curious).
There was a problem hiding this comment.
No clue, it came with a copy-paste from ReactWebWorker-test, I suppose I was just being consistent :). Fixed :).
jimfb
force-pushed
the
webcomponent-to-vendor-thirdparty
branch
from
5f605cc to
4baae69
Compare
jimfb
force-pushed
the
webcomponent-to-vendor-thirdparty
branch
from
4baae69 to
292bead
Compare
…agment as a valid React container.
jimfb
force-pushed
the
webcomponent-to-vendor-thirdparty
branch
from
292bead to
1205929
Compare
|
Rebased, fixed trivial merge conflict. |
jimfb
added a commit
that referenced
this pull request
Mar 16, 2015
Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added webcomponents.js and a simple unit test verifying a document fragment as a valid React container.